Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/client/resourcemanager: parsing additional details from the azure error responses where possible #676

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

tombuildsstuff
Copy link
Contributor

Sometimes the inner message can have more details, meaning we should surface that too. This turns:

ValidationError: The request is not valid

into:

The request is not valid.
Resource name is not valid. It must be between 3 and 26 characters and can only include alphanumeric characters and hyphens.

Spotted in DevCenter

… error responses where possible

Sometimes the inner message can have more details, meaning we should surface that too. This turns:

```
ValidationError: The request is not valid
```

into:

```
The request is not valid.
Resource name is not valid. It must be between 3 and 26 characters and can only include alphanumeric characters and hyphens.
```
@tombuildsstuff tombuildsstuff marked this pull request as ready for review October 12, 2023 10:55
@tombuildsstuff tombuildsstuff requested a review from a team as a code owner October 12, 2023 10:55
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit c17f9e5 into main Oct 13, 2023
6 checks passed
@tombuildsstuff tombuildsstuff deleted the b/parsing-errors-from-base-layer branch October 13, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants